Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PSSA Custom rule violations and opt-in to tests - Fixes #209 #210

Merged
merged 4 commits into from
Mar 30, 2019
Merged

Fix PSSA Custom rule violations and opt-in to tests - Fixes #209 #210

merged 4 commits into from
Mar 30, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Mar 30, 2019 •
edited
Loading

Pull Request (PR) description

Fix PSSA custom rule violations and opted into Common Tests 'Required Script Analyzer Rules',
'Flagged Script Analyzer Rules', 'New Error-Level Script Analyzer Rules'
'Custom Script Analyzer Rules' and 'Relative Path Length'.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Mar 30, 2019
@codecov-io
Copy link

codecov-io commented Mar 30, 2019 •
edited
Loading

Codecov Report

Merging #210 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #210   +/-   ##
==================================
  Coverage   90%    90%           
==================================
  Files        8      8           
  Lines      836    836           
==================================
  Hits       754    754           
  Misses      82     82

johlju
johlju reviewed Mar 30, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 9d4ec01 into dsccommunity:dev Mar 30, 2019
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Mar 30, 2019
@PlagueHO PlagueHO deleted the Issue-209 branch March 30, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@PlagueHO @codecov-io @johlju @kwirkykat